Update the polyfills; fix a type generation error.#5605
Open
bicknellr wants to merge 7 commits intolegacy-undefined-noBatch-onDemandfrom
Open
Update the polyfills; fix a type generation error.#5605bicknellr wants to merge 7 commits intolegacy-undefined-noBatch-onDemandfrom
bicknellr wants to merge 7 commits intolegacy-undefined-noBatch-onDemandfrom
Conversation
sorvell
approved these changes
Nov 14, 2019
sorvell
approved these changes
Nov 14, 2019
sorvell
approved these changes
Nov 18, 2019
Member
Author
|
Lerna didn't update the dependencies in webcomponentsjs during the last publish because the package itself didn't have changes. Fixing in webcomponents/polyfills#244 and then I'll bump here. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
customElementsat load if it's a CustomElementRegistry. webcomponents/polyfills#235, polyfills release, and a version bump here.base = class extends base {};causes a typedeclare class base extends base {}to be emitted but this fails to verify in the next step. Also, I didn't want to ignore everything calledbaseso I renamed it.Includes cherry-picked commits from #5607.